chore(deps): upgrade to celestia-app v1.12.0 #3527
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think we may have to explicitly specify Go 1.22.4 in Dockerfile per https://github.com/celestiaorg/celestia-node/actions/runs/9665348162/job/26662227848?pr=3527#step:4:297 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3527 +/- ##
==========================================
- Coverage 44.83% 44.75% -0.08%
==========================================
Files 265 273 +8
Lines 14620 15385 +765
==========================================
+ Hits 6555 6886 +331
- Misses 7313 7697 +384
- Partials 752 802 +50 ☔ View full report in Codecov by Sentry. |
|
There isn't a tag for alpine 3.18 so will bump that too
|
rootulp
requested review from
renaynay,
Wondertan,
vgonkivs,
distractedm1nd,
walldiss,
ramin and
cristaloleg
as code owners
walldiss
approved these changes
Jun 25, 2024
Wondertan
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
We want testnets to use whichever version of celestia-app is specified by celestia-node's go.mod so this PR bumps the celestia-app dependency so that v1.12.0 can get deployed.